1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • DDMsgReader: When listing messages via lightbar, check if the subject

    From Rob Swindell to GitLab note in main/sbbs on Sun Jun 30 13:14:59 2024
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/442#note_5390

    I suspect with this change, textIsUTF8 will *always* be `true`. Are you actually seeing messages with subjects that are *not* valid UTF-8?

    All ASCII strings are valid UTF-8, while not all UTF-8 strings are valid ASCII.

    You probably mean to write something more like this:
    ```
    str_is_ascii(str) === false && str_is_utf8(str) === true
    ```
  • From Eric Oulashin to GitLab note in main/sbbs on Sun Jun 30 14:01:45 2024
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/442#note_5392

    Logically that makes sense, though it has the same effect in the message list either way. I've updated it to check this way and pushed my changes, and ran another build pipeline.