1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/useredit.cpp

    From Rob Swindell (on Debian Linux) to Git commit to main/sbbs/master on Sat Jun 3 20:06:03 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/653e43e8449bf6b9bfb3a27a
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Hitting Ctrl-C at the "Use external editor" prompt shouldn't change anything
  • From Rob Swindell (on Windows) to Git commit to main/sbbs/master on Thu Sep 14 21:28:57 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/8d60770fa44d0ea8dd09d48b
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Change external editor yes/no prompt default to match current user setting

    Also, although not a bug (because we re-read/parse the user's record every
    menu cycle), don't decrement user.xedit before calling uselect()
    - just not a good practice to not modify variables unnecessarily.
    See the corresponding change to exec.cpp, which was a bug.
  • From Rob Swindell (on Windows) to Git commit to main/sbbs/master on Sat Sep 23 20:29:02 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/d71cce5ffce2d856b8b0f783
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Clear line counter before starting the user settings/config menu.

    Fixes unnecessary [Hit a key] prompt.
  • From Rob Swindell (on Windows 11) to Git commit to main/sbbs/master on Wed Nov 22 15:30:20 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/0bd7a0af71cf7e7b13edc6bc
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Fix CID 32913

    getkeys() could return -1 if user disconnects (and SS_ABORT not set), so this appears to be a valid bug.
  • From Rob Swindell (on Windows 11) to Git commit to main/sbbs/master on Thu Oct 10 12:32:57 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/583ab9195d04961c697a10cd
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Always reload the edited user record from disk after executing a "usercfg_mod"

    Normally, when modifying user fields via JS, the "user modified" node.dab
    flag would be set for that user (on all node's that user is logged-into) and the user record automatically re-read (soon after). But this doesn't work during newuser registration because the user is not yet "logged-into" a node.

    This fixes the issue reported by Nelgin (and observed on amessyroom's BBS) whereby if a new user resets/changes their external message editor, it would not take effect for their new user validation email to the sysop (they would still be using the default new user message editor as configured by the
    sysop).

    It's possible other new user default changes made (e.g. language) would also not have taken immediate effect as a result of this bug (now fixed).
  • From Rob Swindell (on Windows 11)@rob@synchro.net to Git commit to main/sbbs/master on Mon Dec 16 18:24:31 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/207546a2b6e2ce0852852cda
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    openuserdat() was recently changed to not always return -1 on error
  • From Rob Swindell (on Windows 11)@rob@synchro.net to Git commit to main/sbbs/master on Tue Jan 7 16:57:30 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/f7c75dee778e0383c550e0bd
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Populate the security level string being edited with current level (number)

    This appears to have been the original intention (otherwise, why call ultoa?), but was never done. Just a usability/convenience thing, but an apparent bug.
  • From Rob Swindell (on Debian Linux)@rob@synchro.net to Git commit to main/sbbs/master on Mon Jan 20 00:35:27 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/e71c279c5f4f0eaf0310bdf8
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Elminate meaningless typecast
  • From Rob Swindell (on Windows 11)@rob@synchro.net to Git commit to main/sbbs/master on Mon Dec 8 22:29:46 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/8ae00a5795ce733593c2c4ef
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Clean up the sbbs_t::console (JS console.status) bit flags

    Mainly this is renaming CON_R_ECHOX to CON_PASSWORD, but also eliminating several long-unused flags.
  • From Rob Swindell (on Windows 11)@rob@synchro.net to Git commit to main/sbbs/master on Tue Dec 30 16:39:35 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/e891fb86becbb3f383eb47e2
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Remove the user (defaults) config menu that is now handled in user_settings.js

    Since the user config mod defaults to this script name (if blank), there
    was really no way to revert to the hard-coded logic any more anyway.
  • From Rob Swindell (on Debian Linux)@rob@synchro.net to Git commit to main/sbbs/master on Wed May 6 22:36:57 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/8d4a10dfb54ef3d9108a829b
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    useredit: log error if user_config getuserdat fails (CIDs 516411, 530902)

    After invoking the external user-config module the in-memory user_t
    needs to be re-read; if getuserdat fails the caller proceeds with
    stale data. Log the error like purgeuser() already does.

    CID 516411 was originally reported against the now-removed maindflts() function; it appears to have been merged into user_config(), so the
    single fix covers both CIDs.

    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>