1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/js_user.c

    From Rob Swindell to Git commit to main/sbbs/master on Wed May 18 15:32:02 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/65e938974bfeac3448008bfc
    Modified Files:
    src/sbbs3/js_user.c
    Log Message:
    Fix User.number increment beyond lastuser issue

    When the 'number' property of an instance of User was incremented beyond the last user, the call to fgetuserdat() on subsequent property 'get' operation would fail and zero-out the user structure (including the user number). This resulted in an infinite loop in load/birthdays.js where the user number would go from lastuser to 1 in one operation (u.number++).

    Reported by DesotoFireflite (VALHALLA)
  • From Rob Swindell to Git commit to main/sbbs/master on Tue May 31 18:28:27 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/e731ac184d1bb5613cf6fc5f
    Modified Files:
    src/sbbs3/js_user.c
    Log Message:
    Don't clobber an open user.dat file descriptor in js_CreateUserObject()

    Likely fix for the user.dat open file descriptor leak:
    If js_CreateUserObject(cx,parent,cfg,"name",...) is called multiple times
    (e.g. before login and after login), the successive calls will reuse the previously allocated JS object and allocated private data memory. However, the private data memory (which includes the descriptor of an open user.dat file,
    if it has been opened), was always zeroed, even if it was being reused. This would leak open file descriptor.

    So any (pre)login scripts or web scripts that use the "user" object (which
    is all zeroed-out before login) and then allows a user to subsequently login, would leak a file descriptor.
  • From Rob Swindell to Git commit to main/sbbs/master on Sat Jun 11 14:30:02 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/a87cebdb79abc7bdbd163df9
    Modified Files:
    src/sbbs3/js_user.c
    Log Message:
    Add User close() method

    This can be used to force a close of the user.dat file, if open. Rather than waiting for an out of scope User to get garbage-collected, this method could
    be used to force a close of the user.dat file, if it's open.
  • From Rob Swindell (on Windows 11) to Git commit to main/sbbs/master on Sun Jun 9 18:44:32 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/3a029fa8fae8ec897ecb0d43
    Modified Files:
    src/sbbs3/js_user.c
    Log Message:
    Make legacy/alias properties non-enumerable: computer, modem

    I noticed these redundant properties were being logged for every logon in logon.jsonl. We don't need these properties separately enumerable, and really they shouldn't be used anyway.

    computer is an alias of host_name
    modem is an alias of connection
  • From Rob Swindell (on Debian Linux) to Git commit to main/sbbs/master on Tue Oct 15 00:45:21 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/c780c203a091fa500b91fe01
    Modified Files:
    src/sbbs3/js_user.c
    Log Message:
    New user properties: batch_upload_list and batch_download_list

    For exposing the list path/file for a user's batch up/download lists
  • From Rob Swindell (on Debian Linux)@rob@synchro.net to Git commit to main/sbbs/master on Mon Jan 20 12:00:51 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/33d09b8e6cd6b43f1f70ea2b
    Modified Files:
    src/sbbs3/js_user.c
    Log Message:
    A little JSDOC updated text and beautification
  • From Rob Swindell (on Debian Linux)@rob@synchro.net to Git commit to main/sbbs/master on Mon Jan 20 21:14:02 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/3330268bef9ee2184705e425
    Modified Files:
    src/sbbs3/js_user.c
    Log Message:
    Add User.security.deletion_date property

    corresponding wth new user DELDATE field
  • From Deuc╨╡@shurd@sasktel.net to Git commit to main/sbbs/master on Sun Mar 30 11:15:10 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/8b40ce01caed5eb0aa91048b
    Modified Files:
    src/sbbs3/js_user.c
    Log Message:
    Workaround crash

    For now, this is a quick hacky fix. The web server does not store
    an sbbs_t in the context private, so we can't use it here.

    This needs further work.
  • From Deuc╨╡@shurd@sasktel.net to Git commit to main/sbbs/master on Sun Mar 30 11:47:39 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/89d2e6c50ea27414e3df4d2f
    Modified Files:
    src/sbbs3/js_user.c
    Log Message:
    Fix terminal update

    We only do this in the terminal server... to detect this, check if the
    global object has a bbs object that is of the BBS class. If it does,
    the context private will be an sbbs_t pointer.