1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/logfile.cpp

    From Rob Swindell to Git commit to main/sbbs/master on Sun Dec 20 17:11:56 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/48f73ca167262efb1a09078f
    Modified Files:
    src/sbbs3/logfile.cpp
    Log Message:
    Don't log errno info for ERR_CHK errormsg() calls

    The errno (global error number) information is not relevant for any sbbs "checking" type errors.
    Also, use safe_strerror() for thread-safe errno descriptions.
  • From Rob Swindell to Git commit to main/sbbs/master on Sun May 16 16:47:09 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/3d1e05e5015a0872a2a72fb7
    Modified Files:
    src/sbbs3/logfile.cpp
    Log Message:
    Log the current Git branch and hash along with every error

    This eliminates any ambiguity about what exact version was in use when each error is logged.
  • From Rob Swindell to Git commit to main/sbbs/master on Thu Dec 29 14:16:20 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/4908a3883646356c357f6814
    Modified Files:
    src/sbbs3/logfile.cpp
    Log Message:
    Resolve warning: ISO C++ forbids converting a string constant to ‘char*’
  • From Rob Swindell to Git commit to main/sbbs/master on Mon Jan 30 16:00:04 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/d99905a420dd2f394c5dce69
    Modified Files:
    src/sbbs3/logfile.cpp
    Log Message:
    Lowercase the topics in hack and spam action messages
  • From Rob Swindell (on Windows 11) to Git commit to main/sbbs/master on Sun Feb 25 18:06:16 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/62852439c523e1d09e6b10b1
    Modified Files:
    src/sbbs3/logfile.cpp
    Log Message:
    Don't log errno value and description as part of ERROR log msg, when 0

    If errno is 0, it's definitely no proividing anything of value here. Of
    course, sometimes errno might be non-zero and still be unrelated to the error message. <shrug>

    For Nelgin:
    !ERROR 0 (Success) in exec.cpp line 644 (js_execfile) compiling "something.js" access=0
    <nelgin> I don't quite get why a successful execution is logged as an error
  • From Rob Swindell (on Windows 11) to Git commit to main/sbbs/master on Thu Oct 17 21:57:19 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/1fecea061764630c37d903bc
    Modified Files:
    src/sbbs3/logfile.cpp
    Log Message:
    Fix extra line feed (and blank line) when long (> 78 char) strings were logged

    to node.log via sbbs_t::log()
  • From Rob Swindell (on Debian Linux)@rob@synchro.net to Git commit to main/sbbs/master on Wed Dec 4 18:48:28 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/5f89c517d8d4a1b65f1de4bd
    Modified Files:
    src/sbbs3/logfile.cpp
    Log Message:
    De-duplicate repeated errors logged via sbbs_t::errormsg() by reducing severity

    ... from ERROR to WARNING, so the repeats won't be logged to error.log file
    and won't (normally) be sent as notifications (e.g. emails) to the sysop. The duplicates are identified as from the same source file and line number as the immediately previous logged error within the last 12 hours. String comparison doesn't really work for deduplication since if you look closely, the errors usually are *not* exact duplicates (i.e. there's a node number or a socket descriptor or something that uniquely identifies the user/client/session). Repeated errors don't increment the node's error counter either.

    This does not de-duplicate errors logged via other means (e.g. direct calls to log()/lputs(),lprintf() with a severity of LOG_ERR or higher), but will
    solve the majority of duplicate errors that can be logged from the terminal server.

    So this at least partially addresses issue #619.