• Static code analysis

    From Michael Dukelsky@2:5020/1042 to All on Mon Feb 15 18:26:44 2021
    Hello All,

    I've started using static code analysis for improving the code. At the moment I've applied the static analysis to huskylib and smapi and pushed the results to the master branch. I tested compilation in Windows using Visual Studio 2019 and in linux using gcc 10.2.1. Please check whether it compiles in OS/2.

    PVS-Studio was used for static analysis of the projects. https://www.viva64.com/en/pvs-studio/

    Michael

    ... node (at) f1042 (dot) ru
    --- GoldED+/LNX 1.1.5-b20180707
    * Origin: Moscow, Russia (2:5020/1042)
  • From Tommi Koivula@2:221/1 to Michael Dukelsky on Tue Feb 16 21:23:10 2021

    15 Feb 21 18:26, Michael Dukelsky wrote to All:

    Please check whether it compiles in OS/2.

    No problems.

    'Tommi

    ---
    * Origin: rbb.fidonet.fi (2:221/1)
  • From Michael Pierce@1:105/81 to Michael Dukelsky on Tue Feb 16 16:17:44 2021

    Hello Michael!

    15 Feb 21 18:26, you wrote to all:

    Hello All,

    I've started using static code analysis for improving the code. At the moment I've applied the static analysis to huskylib and smapi and
    pushed the results to the master branch. I tested compilation in
    Windows using Visual Studio 2019 and in linux using gcc 10.2.1. Please check whether it compiles in OS/2.

    when you say master branch, where do you mean??

    I got the following to compile:
    https://github.com/zoomosis/huskylib
    https://github.com/zoomosis/smapi
    https://github.com/zoomosis/fidoconf
    https://github.com/zoomosis/areafix

    but hpt did not
    here is the output of wmake

    Open Watcom Make Version 2.0beta1 Limited Availability
    Portions Copyright (c) 1988-2002 Sybase, Inc. All Rights Reserved.
    Source code is available under the Sybase Open Watcom Public License.
    See http://www.openwatcom.org/ for details.
    wcl386 -zq -bt=os2v2 -l=os2v2 -I..\h -I..\..\huskylib -I..\..\fidoconf -I..\..\smapi -I..\..\areafix -Fe=pktinfo.exe ..\src\pktinfo.c ..\src\dupe.c ..\src\pktread.c ..\src\fcommon.c ..\src\global.c ..\..\huskylib\make\huskywco.lib ..\..\fidoconf\make\fconfwco.lib ..\..\smapi\make\smapiwco.lib ..\..\areafix\make\afixwco.lib
    Error! E2028: gettimeofday_ is an undefined reference
    file ..\..\huskylib\make\huskywco.lib(C:\home\src\husky\huskylib\src\tdelay.c): undefined symbol gettimeofday_
    Error: Linker returned a bad status
    wcl386 -zq -bt=os2v2 -l=os2v2 -I..\h -I..\..\huskylib -I..\..\fidoconf -I..\..\smapi -I..\..\areafix -Fe=tpkt.exe ..\src\tpkt.c ..\src\global.c ..\src\pktread.c ..\src\pktwrite.c ..\src\fcommon.c ..\src\dupe.c ..\..\huskylib\make\huskywco.lib ..\..\fidoconf\make\fconfwco.lib ..\..\smapi\make\smapiwco.lib ..\..\areafix\make\afixwco.lib
    Error! E2028: gettimeofday_ is an undefined reference
    file ..\..\huskylib\make\huskywco.lib(C:\home\src\husky\huskylib\src\tdelay.c): undefined symbol gettimeofday_
    Error: Linker returned a bad status
    wcl386 -zq -bt=os2v2 -l=os2v2 -I..\h -I..\..\huskylib -I..\..\fidoconf -I..\..\smapi -I..\..\areafix -Fe=txt2pkt.exe ..\src\txt2pkt.c ..\src\global.c ..\src\pktread.c ..\src\pktwrite.c ..\src\fcommon.c ..\src\dupe.c ..\..\huskylib\make\huskywco.lib ..\..\fidoconf\make\fconfwco.lib ..\..\smapi\make\smapiwco.lib ..\..\areafix\make\afixwco.lib
    Error! E2028: gettimeofday_ is an undefined reference
    file ..\..\huskylib\make\huskywco.lib(C:\home\src\husky\huskylib\src\tdelay.c): undefined symbol gettimeofday_
    Error: Linker returned a bad status
    wcl386 -zq -bt=os2v2 -l=os2v2 -I..\h -I..\..\huskylib -I..\..\fidoconf -I..\..\smapi -I..\..\areafix -Fe=hptlink.exe ..\src\hptlink.c ..\src\global.c ..\..\huskylib\make\huskywco.lib ..\..\fidoconf\make\fconfwco.lib ..\..\smapi\make\smapiwco.lib ..\..\areafix\make\afixwco.lib
    ..\src\hptlink.c(657): Warning! W136: Comparison equivalent to 'unsigned == 0' ..\src\hptlink.c(671): Warning! W136: Comparison equivalent to 'unsigned == 0' Warning! W1027: file global.obj(C:\home\src\husky\hpt\src\global.c): redefinition of _config ignored
    Warning! W1027: file global.obj(C:\home\src\husky\hpt\src\global.c): redefinition of _versionStr ignored
    Error! E2028: gettimeofday_ is an undefined reference
    file ..\..\huskylib\make\huskywco.lib(C:\home\src\husky\huskylib\src\tdelay.c): undefined symbol gettimeofday_
    Error: Linker returned a bad status
    wcl386 -zq -bt=os2v2 -l=os2v2 -I..\h -I..\..\huskylib -I..\..\fidoconf -I..\..\smapi -I..\..\areafix -Fe=hpttree.exe ..\src\hpttree.c ..\..\huskylib\make\huskywco.lib ..\..\fidoconf\make\fconfwco.lib ..\..\smapi\make\smapiwco.lib ..\..\areafix\make\afixwco.lib
    Error! E2028: gettimeofday_ is an undefined reference
    file ..\..\huskylib\make\huskywco.lib(C:\home\src\husky\huskylib\src\tdelay.c): undefined symbol gettimeofday_
    Error: Linker returned a bad status
    wcl386 -zq -bt=os2v2 -l=os2v2 -I..\h -I..\..\huskylib -I..\..\fidoconf -I..\..\smapi -I..\..\areafix -Fe=hpt.exe ..\src\hpt.c ..\src\global.c ..\src\pktread.c ..\src\pktwrite.c ..\src\fcommon.c ..\src\toss.c ..\src\scan.c ..\src\scanarea.c ..\src\post.c ..\src\hptafix.c ..\src\dupe.c ..\src\seenby.c ..\src\link.c ..\src\carbon.c ..\..\huskylib\make\huskywco.lib ..\..\fidoconf\make\fconfwco.lib ..\..\smapi\make\smapiwco.lib ..\..\areafix\make\afixwco.lib
    ..\src\toss.c(3204): Warning! W1181: Parameter 1, sign specifier mismatch ..\src\toss.c(3204): Note! N2003: source conversion type is 'unsigned long *' ..\src\toss.c(3204): Note! N2004: target conversion type is 'long *' ..\src\toss.c(3218): Warning! W1181: Parameter 1, sign specifier mismatch ..\src\toss.c(3218): Note! N2003: source conversion type is 'unsigned long *' ..\src\toss.c(3218): Note! N2004: target conversion type is 'long *' ..\src\toss.c(3230): Warning! W1181: Parameter 1, sign specifier mismatch ..\src\toss.c(3230): Note! N2003: source conversion type is 'unsigned long *' ..\src\toss.c(3230): Note! N2004: target conversion type is 'long *'
    Error! E2028: gettimeofday_ is an undefined reference
    file ..\..\huskylib\make\huskywco.lib(C:\home\src\husky\huskylib\src\tdelay.c): undefined symbol gettimeofday_
    Error: Linker returned a bad status

    Thanks,
    Michael

    --- GoldED+/LNX 1.1.5-b20180707
    * Origin: Our Awesome Net - Portland, OR - awesome.abon.us (1:105/81)
  • From Michael Dukelsky@2:5020/1042 to Michael Pierce on Wed Feb 17 09:36:22 2021
    Hello Michael,

    Tuesday February 16 2021, Michael Pierce wrote to Michael Dukelsky:

    I've started using static code analysis for improving the code.
    At the moment I've applied the static analysis to huskylib and
    smapi and pushed the results to the master branch. I tested
    compilation in Windows using Visual Studio 2019 and in linux
    using gcc 10.2.1. Please check whether it compiles in OS/2.

    when you say master branch, where do you mean??

    I mean master branch in the repository.

    $ git status
    On branch master
    ^^^^^^^^^^^^^ This is the branch in my local repository which I cloned
    from github.
    Your branch is up to date with 'origin/master'.
    ^^^^^^^^^^^^^
    And this is the same branch in the remote repository on
    github.

    I did development in a separate temporary branch. After finishing I merged the temporary branch with the master branch, so that all the made changes are now in the master branch. And then I deleted the temporary branch.

    I got the following to compile:
    https://github.com/zoomosis/huskylib
    https://github.com/zoomosis/smapi
    https://github.com/zoomosis/fidoconf
    https://github.com/zoomosis/areafix

    but hpt did not
    here is the output of wmake

    Open Watcom Make Version 2.0beta1 Limited Availability
    Portions Copyright (c) 1988-2002 Sybase, Inc. All Rights Reserved.
    Source code is available under the Sybase Open Watcom Public License.
    See http://www.openwatcom.org/ for details.
    wcl386 -zq -bt=os2v2 -l=os2v2 -I..\h -I..\..\huskylib -I..\..\fidoconf -I..\..\smapi -I..\..\areafix -Fe=pktinfo.exe ..\src\pktinfo.c ..\src\dupe.c ..\src\pktread.c ..\src\fcommon.c ..\src\global.c ..\..\huskylib\make\huskywco.lib ..\..\fidoconf\make\fconfwco.lib ..\..\smapi\make\smapiwco.lib ..\..\areafix\make\afixwco.lib Error! E2028: gettimeofday_ is an
    undefined reference file ..\..\huskylib\make\huskywco.lib(C:\home\src\husky\huskylib\src\tdelay .c): undefined symbol gettimeofday_
    Error: Linker returned a bad status

    gettimeofday should be in libc. Maybe OS/2 users may help you.

    Michael

    ... node (at) f1042 (dot) ru
    --- GoldED+/LNX 1.1.5-b20180707
    * Origin: Moscow, Russia (2:5020/1042)
  • From Oli@2:280/464.47 to Michael Pierce on Wed Feb 17 08:21:19 2021
    Michael wrote (2021-02-16):

    Hello Michael!

    15 Feb 21 18:26, you wrote to all:

    Hello All,

    I've started using static code analysis for improving the code. At
    the moment I've applied the static analysis to huskylib and smapi
    and pushed the results to the master branch. I tested compilation in
    Windows using Visual Studio 2019 and in linux using gcc 10.2.1.
    Please check whether it compiles in OS/2.

    when you say master branch, where do you mean??

    I got the following to compile:
    https://github.com/zoomosis/huskylib
    https://github.com/zoomosis/smapi
    https://github.com/zoomosis/fidoconf
    https://github.com/zoomosis/areafix

    this is andrew's fork, which is slightly behind the official repo and has not included the static code analysis commits (yet). The official huskyproject repo is at (I guess it doesn't include the commits for watcom):

    https://github.com/huskyproject/huskylib
    https://github.com/huskyproject/smapi
    ....

    ---
    * Origin: . (2:280/464.47)
  • From andrew clarke@3:633/267 to Michael Pierce on Wed Feb 17 19:10:36 2021
    On Tue 2021-02-16 16:17:44, Michael Pierce (1:105/81) wrote to Michael Dukelsky:

    I got the following to compile:
    https://github.com/zoomosis/huskylib
    https://github.com/zoomosis/smapi
    https://github.com/zoomosis/fidoconf
    https://github.com/zoomosis/areafix

    This is my fork. Michael Dukelsky is working on the mainline Husky repo. I haven't included his latest patches in my fork and would prefer my Watcom patches be merged into the mainline Husky code which will make my fork redundant.

    but hpt did not
    here is the output of wmake

    Open Watcom Make Version 2.0beta1 Limited Availability
    Portions Copyright (c) 1988-2002 Sybase, Inc. All Rights Reserved.
    Source code is available under the Sybase Open Watcom Public License.
    See http://www.openwatcom.org/ for details.

    Looking at the above WMake version you're using an old snapshot of OW 2.0.

    This is the output of a recent version:

    Open Watcom Make Version 2.0 beta Feb 13 2021 13:37:09 (64-bit)
    Copyright (c) 2002-2021 The Open Watcom Contributors. All Rights Reserved. Portions Copyright (c) 1988-2002 Sybase, Inc. All Rights Reserved.
    Source code is available under the Sybase Open Watcom Public License.
    See http://www.openwatcom.org/ for details.

    wcl386 -zq -bt=os2v2 -l=os2v2 -I..\h -I..\..\huskylib -I..\..\fidoconf -I..\..\smapi -I..\..\areafix -Fe=pktinfo.exe ..\src\pktinfo.c ..\src\dupe.c ..\src\pktread.c ..\src\fcommon.c ..\src\global.c ..\..\huskylib\make\huskywco.lib ..\..\fidoconf\make\fconfwco.lib ..\..\smapi\make\smapiwco.lib ..\..\areafix\make\afixwco.lib Error! E2028: gettimeofday_ is an
    undefined reference

    gettimeofday() is used by tdelay.c in Huskylib. gnmsgid.exe won't build without it.

    Evidently that function is missing in your old version of OW2.0, for OS/2 targets at least.
    So you need to upgrade your copy of OW2.0.

    After you've done that, do a clean rebuild of HPT for each module.

    You can create a batch file, eg. MAKEOS2.CMD:

    cd huskylib\make
    wmake -h -f makefile.watcom OS2=1 clean
    wmake -h -f makefile.watcom OS2=1
    cd ..\..

    cd smapi\make
    wmake -h -f makefile.watcom OS2=1 clean
    wmake -h -f makefile.watcom OS2=1
    cd ..\..

    cd fidoconf\make
    wmake -h -f makefile.watcom OS2=1 clean
    wmake -h -f makefile.watcom OS2=1
    cd ..\..

    cd areafix\make
    wmake -h -f makefile.watcom OS2=1 clean
    wmake -h -f makefile.watcom OS2=1
    cd ..\..

    cd hpt\make
    wmake -h -f makefile.watcom OS2=1 clean
    wmake -h -f makefile.watcom OS2=1

    --- GoldED+/BSD 1.1.5-b20180707
    * Origin: Blizzard of Ozz, Melbourne, Victoria, Australia (3:633/267)
  • From Michael Dukelsky@2:5020/1042 to andrew clarke on Wed Feb 17 13:02:26 2021
    Hello andrew,

    Wednesday February 17 2021, andrew clarke wrote to Michael Pierce:

    I got the following to compile:
    https://github.com/zoomosis/huskylib
    https://github.com/zoomosis/smapi
    https://github.com/zoomosis/fidoconf
    https://github.com/zoomosis/areafix

    This is my fork.

    I did not pay attention to what was written after github.com/ :-(

    Michael Dukelsky is working on the mainline Husky
    repo. I haven't included his latest patches in my fork and would
    prefer my Watcom patches be merged into the mainline Husky code which
    will make my fork redundant.

    Please make pull requests, I'll merge them.

    Michael


    ... node (at) f1042 (dot) ru
    --- GoldED+/LNX 1.1.5-b20180707
    * Origin: Moscow, Russia (2:5020/1042)
  • From andrew clarke@3:633/267 to Michael Dukelsky on Wed Feb 17 22:03:14 2021
    On Wed 2021-02-17 13:02:26, Michael Dukelsky (2:5020/1042) wrote to andrew clarke:

    This is my fork.

    I did not pay attention to what was written after github.com/ :-(

    :-)

    Michael Dukelsky is working on the mainline Husky
    repo. I haven't included his latest patches in my fork and would
    prefer my Watcom patches be merged into the mainline Husky code
    which will make my fork redundant.

    Please make pull requests, I'll merge them.

    OK, pull requests coming soon. Thank you.

    --- GoldED+/BSD 1.1.5-b20180707
    * Origin: Blizzard of Ozz, Melbourne, Victoria, Australia (3:633/267)
  • From Michael Pierce@1:105/81 to andrew clarke on Wed Feb 17 08:02:10 2021

    Hello andrew!
    Looking at the above WMake version you're using an old snapshot of OW
    2.0.

    This is the output of a recent version:
    Evidently that function is missing in your old version of OW2.0, for
    OS/2 targets at least. So you need to upgrade your copy of OW2.0.

    I got my version on sourceforge.net - did not see that there was one on github have pulled latest version from https://github.com/open-watcom/open-watcom-v2/releases

    would be nice if sourceforge was up-to-date
    will try again

    Michael


    --- GoldED+/LNX 1.1.5-b20180707
    * Origin: Our Awesome Net - Portland, OR - awesome.abon.us (1:105/81)
  • From Michael Pierce@1:105/81 to andrew clarke on Wed Feb 17 14:14:36 2021

    Hello andrew!
    Thought I'd pass along status and also importantly what it took to get to this point

    first, I was using what I thought was curren version of open-watcom from sourceforge.net - found more recent version from github, applied that
    got the exact same error - so uninstalled, reboot, re-install, re-compile, still got same error - had to uninstall, reboot, tried to delete c:\watcom folder and all subfolders - got error - turns out had to unlock nmpbind.exe (in c:\watcom\binp) did that, deleted folder, rebooted, re-installed, rebooted, recompiled, this time everything compiled

    I do hope who ever is working on open-watcom is reading this.. so they can fix that problem


    still not out of the woods yet though - now getting a different error

    hpt toss scan pack
    SMAPI ERROR: wrongly sized subfield occured!

    any ideas?

    Thanks,
    Michael

    ---
    * Origin: Our Awesome Net - Portland, OR - awesome.abon.us (1:105/81)
  • From andrew clarke@3:633/267 to Michael Pierce on Thu Feb 18 11:45:18 2021
    On 2021-02-17 14:14:36, Michael Pierce (1:105/81) wrote to andrew clarke:

    Thought I'd pass along status and also importantly what it took to get
    to this point

    first, I was using what I thought was curren version of open-watcom from sourceforge.net - found more recent version from github, applied
    that got the exact same error - so uninstalled, reboot, re-install, re-compile, still got same error - had to uninstall, reboot, tried to delete c:\watcom folder and all subfolders - got error - turns out had
    to unlock nmpbind.exe (in c:\watcom\binp) did that, deleted folder, rebooted, re-installed, rebooted, recompiled, this time everything compiled

    I do hope who ever is working on open-watcom is reading this.. so they
    can fix that problem

    The OS/2 installer probably has NMPBIND.EXE loading from CONFIG.SYS, which then runs in the background. You don't actually need NMPBIND.EXE running for the compiler to work though.

    I prefer to untar ow-snapshot.tar.gz to D:\WATCOM without running the installer, so my CONFIG.SYS stays unmodified.

    I have an OS/2 .cmd file that sets the minimum envvars that wcl386 needs:

    set WATCOM=d:\watcom
    set PATH=%WATCOM%\binp;%PATH%
    set BEGINLIBPATH=%WATCOM%\binp\dll;%BEGINLIBPATH%
    set INCLUDE=%WATCOM%\h;%WATCOM%\h\os2

    still not out of the woods yet though - now getting a different error

    hpt toss scan pack
    SMAPI ERROR: wrongly sized subfield occured!

    any ideas?

    Not good. Possibly a corrupt JAM base?

    I wouldn't expect the OW2.0 port to have caused it, but hasn't been tested much, so beware.

    structrw.c- if(pbuf + JAM_SF_HEADER_SIZE + size > limit)
    structrw.c- /* it means that subfield claims to be longer
    structrw.c- than header says. can't be. */
    structrw.c- {
    structrw.c- /* just break, ideally there shall be a setting for lax treatment of messagebase */
    structrw.c: printf("SMAPI ERROR: wrongly sized subfield occured!\n");
    structrw.c- break;
    structrw.c- }

    --- GoldED+/BSD 1.1.5-b20180707
    * Origin: Blizzard of Ozz, Melbourne, Victoria, Australia (3:633/267)
  • From Michael Dukelsky@2:5020/1042 to andrew clarke on Thu Feb 18 12:39:58 2021
    Hello andrew,

    Wednesday February 17 2021, andrew clarke wrote to Michael Dukelsky:

    Michael Dukelsky is working on the mainline Husky
    repo. I haven't included his latest patches in my fork and would
    prefer my Watcom patches be merged into the mainline Husky code
    which will make my fork redundant.

    Please make pull requests, I'll merge them.

    OK, pull requests coming soon. Thank you.

    I merged your pull requests for huskylib, smapi, fidoconf, areafix and hpt. Thank you for the good job.

    It would be nice to add htick and maybe msged.

    Michael

    ... node (at) f1042 (dot) ru
    --- GoldED+/LNX 1.1.5-b20180707
    * Origin: Moscow, Russia (2:5020/1042)
  • From andrew clarke@3:633/267 to Michael Dukelsky on Thu Feb 18 22:27:14 2021
    On 2021-02-18 12:39:58, Michael Dukelsky (2:5020/1042) wrote to andrew clarke:

    I merged your pull requests for huskylib, smapi, fidoconf, areafix and hpt. Thank you for the good job.

    You're welcome. :)

    It would be nice to add htick and maybe msged.

    I think so too.

    PS. My changes to README.md for some of the above modules refer to the OW2.0 fork, so you should revert those changes to avoid confusion.

    --- GoldED+/BSD 1.1.5-b20180707
    * Origin: Blizzard of Ozz, Melbourne, Victoria, Australia (3:633/267)
  • From andrew clarke@3:633/267 to Michael Pierce on Fri Feb 19 07:20:46 2021
    On 2021-02-17 14:14:36, Michael Pierce (1:105/81) wrote to andrew clarke:

    still not out of the woods yet though - now getting a different error

    hpt toss scan pack
    SMAPI ERROR: wrongly sized subfield occured!

    There's definitely NQR in the JAM code in the OW2.0 version on Windows:

    H:\tmp\hpt>hpt scan
    1 07:18:16 Start
    1 07:18:16 Start scanning...
    1 07:18:16 EchoTossLogFile not found -> Scanning all areas
    1 07:18:16 Scanning area: jamtest
    Assertion Failed: subfieldNext->Buffer <= (byte *)*subfield + subfield[0]->arraySize, function decode_subfield, file ../src/structrw.c, line 961.
    ABNORMAL TERMINATION

    H:\tmp\hpt>hptlink
    hptlink/w32-wc 1.9.0-cur 2021-02-17

    F 07:18:42 hptlink/w32-wc 1.9.0-cur 2021-02-17
    C 07:18:42 No ImportLog file, linking all Areas
    3 07:18:42 linking area netmail...
    A 07:18:42 Could not open area netmail
    3 07:18:42 linking area jamtest...
    Assertion Failed: subfieldNext->Buffer <= (byte *)*subfield + subfield[0]->arraySize, function decode_subfield, file ../src/structrw.c, line 961.
    ABNORMAL TERMINATION

    I'm unfamiliar with the JAM format and don't really understand the code there. The code in structrw.c is supposed to be portable, but evidently not.

    The good news is OW2.0 HPT doesn't seem to be writing corrupt data, since the MSVC port of HPT (from husky-all-1.9-w32msvc6dll-perl510-hptzip-20201211.zip) can still read JAMTEST:

    H:\tmp\hpt>hpt-msvc scan
    1 07:28:38 Start
    1 07:28:38 Start scanning...
    1 07:28:38 EchoTossLogFile not found -> Scanning all areas
    1 07:28:38 Scanning area: jamtest
    D 07:28:38 Statistics
    D 07:28:38 areas: 1 msgs: 5
    D 07:28:38 exported: 0
    E 07:28:38 Areas summary:
    1 07:28:38 End

    And GoldED doesn't throw any errors reading it.

    --- GoldED+/BSD 1.1.5-b20180707
    * Origin: Blizzard of Ozz, Melbourne, Victoria, Australia (3:633/267)
  • From Michael Pierce@1:105/81 to andrew clarke on Thu Feb 18 14:18:44 2021
    On 2021-02-17 14:14:36, Michael Pierce (1:105/81) wrote to andrew
    clarke:

    still not out of the woods yet though - now getting a different
    error

    hpt toss scan pack
    SMAPI ERROR: wrongly sized subfield occured!

    There's definitely NQR in the JAM code in the OW2.0 version on
    Windows:

    I'm unfamiliar with the JAM format and don't really understand the
    code there. The code in structrw.c is supposed to be portable, but evidently not.

    The good news is OW2.0 HPT doesn't seem to be writing corrupt data,
    since the MSVC port of HPT (from husky-all-1.9-w32msvc6dll-perl510-hptzip-20201211.zip) can still read JAMTEST:

    And GoldED doesn't throw any errors reading it.

    for some reason, I can not get hpt to "see" any sort of packets?
    I have unzipped the packets in to inbound folder, and hpt does do anything with them, even reduced it down to 1 packet. no error from hpt, nor in hpt.log, and tparser is worthless, it does not show any sort of error

    I have hpt in c:\ele (elebbs) so my config is in there as well
    I have tried with the \\ and on this config, it does complain when using \\

    what am I missing?

    below is my current hpt config

    === Cut ===
    # main fidoconfig file
    name Mike's Point
    sysop Michael Pierce
    location Portland, Oregon
    address 1:105/105
    inbound C:\ELE\FIDO\INB\UNSECURE\
    protinbound C:\ELE\FIDO\INB\
    outbound c:\bink\outb
    tempinbound c:\ele\fido\tmp\inb\
    tempoutbound c:\ele\fido\tmp\outb\
    logfiledir c:\ele\log\
    dupehistorydir c:\ele\fido\dupebase\
    msgbasedir c:\ele\msgs\
    echotosslog c:\ele\log\toss.log
    importlog c:\ele\log\import.log
    # Nodelist Section
    nodelist NODELIST.999
    nodelistdir c:\ele\fido\
    FullUpdate c:\ele\fido\NODELIST
    DefaultZone 1
    FidoUserList FIDOUSER.LST
    NodelistFormat standard

    linkwithimportlog kill
    separatebundles yes
    disablepid yes
    disabletid yes
    # hptperlfile c:\ele\fido\lib\hptfunctions.pl
    pack zip "zip -9 -j -q $a $f"
    #pack zip 7z $a$f
    unpack "unzip -j -Loqq $a $f -d $p" 0 504b0304
    # unpack "arc eno $a $p'*.*'" 0 1a

    robotsarea NETMAIL

    robot default
    killrequests yes
    reportsattr loc pvt k/s npd

    robot areafix
    fromname Areafix robot
    robotorigin Areafix robot
    linkdefaults begin
    allowemptypktpwd secure
    packer zip
    areafixautocreate on
    areafixautocreatedefaults -b jam -dupecheck del -dupehistory 14
    echomailflavour direct
    forwardrequests off
    linkdefaults end

    include c:\ele\fido\links
    include c:\ele\fido\route

    netmailarea NETMAIL c:\ele\msgs\netmail -b msg
    badarea BAD c:\ele\msgs\bad -b msg
    dupearea DUPE c:\ele\msgs\dupe -b msg
    localarea PERSONAL.MAIL c:\ele\msgs\personal -b msg

    include c:\ele\fido\areasfido
    netmailflag c:\ele\fido\netmail.out
    === Cut ===


    Michael


    --- GoldED+/LNX 1.1.5-b20180707
    * Origin: Our Awesome Net - Portland, OR - awesome.abon.us (1:105/81)
  • From andrew clarke@3:633/267 to Michael Pierce on Fri Feb 19 11:28:10 2021
    On 2021-02-18 14:18:44, Michael Pierce (1:105/81) wrote to andrew clarke:

    for some reason, I can not get hpt to "see" any sort of packets?
    I have unzipped the packets in to inbound folder, and hpt does do
    anything with them, even reduced it down to 1 packet. no error from hpt, nor in hpt.log, and tparser is worthless, it does not show any sort of error

    I can't reproduce that here.

    I generated a dummy 'pierce.pkt':

    c:\ele>copy pierce.pkt fido\inb

    c:\ele>hpt toss
    1 14:54:20 Start
    1 14:54:20 Start tossing...
    7 14:54:20 pkt: C:\ELE\FIDO\INB\pierce.tos [1:105/81]
    A 14:54:20 pkt: C:\ELE\FIDO\INB\pierce.tos No Link for 1:105/81.0, processing only Netmail
    A 14:54:20 Renaming pkt/arc to .sec
    4 14:54:20 Statistics:
    4 14:54:20 arc: 0 netMail: 0 echoMail: 0 CC: 0
    4 14:54:20 pkt's: 1 dupe: 0 passthru: 0 exported: 0
    4 14:54:20 msgs: 0 bad: 0 saved: 0 empty: 0
    4 14:54:20 Input: 0.00 mails/sec Output: 0.00 mails/sec
    4 14:54:20 43.46 kb/sec
    4 14:54:20 0.17 kb total, processed in 0.004 seconds
    4 14:54:20 Areas summary:
    1 14:54:20 End tossing
    1 14:54:20 End

    Put these in your hpt.cfg to help debugging:

    LogLevels 12345789ACDEFGHIJKLMNPQRSTVWX
    ScreenLogLevels 12345789ACDEFGHIJKLMNPQRSTVWX
    LogEchoToScreen On

    I have hpt in c:\ele (elebbs) so my config is in there as well
    I have tried with the \\ and on this config, it does complain when
    using \\

    \ is fine

    --- GoldED+/BSD 1.1.5-b20180707
    * Origin: Blizzard of Ozz, Melbourne, Victoria, Australia (3:633/267)
  • From andrew clarke@3:633/267 to Michael Pierce on Sun Feb 21 07:59:54 2021
    On 2021-02-19 07:20:46, andrew clarke (3:633/267) wrote to Michael Pierce:

    There's definitely NQR in the JAM code in the OW2.0 version on Windows:

    H:\tmp\hpt>> hpt scan
    1 07:18:16 Start
    1 07:18:16 Start scanning...
    1 07:18:16 EchoTossLogFile not found -> Scanning all areas
    1 07:18:16 Scanning area: jamtest
    Assertion Failed: subfieldNext->Buffer <= (byte *)*subfield + subfield[0]->arraySize, function decode_subfield, file
    ../src/structrw.c, line 961. ABNORMAL TERMINATION

    To my surprise I got this error on FreeBSD too.

    Turns out it was an upstream bug in structrw.c, introduced on 2021-02-14, that affected all platforms.

    old:

    - len = sizeof(JAMSUBFIELD2LIST) + count *
    - (sizeof(JAMSUBFIELD2) - JAM_SF_HEADER_SIZE + 1) + *SubfieldLen;

    new:

    + len = offsetof(JAMSUBFIELD2LIST, subfield) + count *
    + (sizeof(JAMSUBFIELD2) - JAM_SF_HEADER_SIZE + 1) + (size_t)*SubfieldLen;

    Evidently these two things don't do the same thing. :)

    I've reverted the change in the zoomosis/smapi repo, which will hopefully be reverted upstream shortly.

    --- GoldED+/BSD 1.1.5-b20180707
    * Origin: Blizzard of Ozz, Melbourne, Victoria, Australia (3:633/267)
  • From Michael Pierce@1:105/81 to andrew clarke on Sat Feb 20 16:08:42 2021
    Hello andrew!


    LogLevels 12345789ACDEFGHIJKLMNPQRSTVWX
    ScreenLogLevels 12345789ACDEFGHIJKLMNPQRSTVWX
    LogEchoToScreen On

    I have hpt in c:\ele (elebbs) so my config is in there as well
    I have tried with the \\ and on this config, it does complain
    when using \\

    \ is fine

    set levels to what you posted... it does not generate any error of any kind, I tried with msg format, nothing no errors, it just does not seem to see the packet or open it.. this has also been re-produced by Rick Smith as well

    so what else could be missing?



    Michael


    --- GoldED+/LNX 1.1.5-b20180707
    * Origin: Our Awesome Net - Portland, OR - awesome.abon.us (1:105/81)
  • From andrew clarke@3:633/267 to Michael Pierce on Sun Feb 21 14:10:40 2021
    On 2021-02-20 16:08:42, Michael Pierce (1:105/81) wrote to andrew clarke:

    LogLevels 12345789ACDEFGHIJKLMNPQRSTVWX
    ScreenLogLevels 12345789ACDEFGHIJKLMNPQRSTVWX
    LogEchoToScreen On

    I have hpt in c:\ele (elebbs) so my config is in there as well
    I have tried with the \\ and on this config, it does complain
    when using \\

    \ is fine

    set levels to what you posted... it does not generate any error of any kind, I tried with msg format, nothing no errors, it just does not seem
    to see the packet or open it.. this has also been re-produced by Rick Smith as well

    so what else could be missing?

    Nothing springs to mind.

    Do you get any output at all? Make sure those LogLevels etc commands come first in your HPT.CFG, because HPT processes the config file commands in order.

    If still nothing, post a minimal config file here with the error so I can replicate it.

    You could also run it through a debugger.

    --- GoldED+/BSD 1.1.5-b20180707
    * Origin: Blizzard of Ozz, Melbourne, Victoria, Australia (3:633/267)